Updating FSPS #236
Merged
Updating FSPS #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This PR includes updates to the shape (and contents) of data files in FSPS, especially the nebular emission tables and the XSP spectra. I think we need a new release after this is merged, happy to generate the rc. I'm not sure why the macos_arm64 build test was cancelled - I may have closed and reopened the PR too quickly, but it also says something about not enough compute credits. |
Owner
|
I think the credits warning is a red herring. I've restarted the build to double check. After that, please feel free to merge and make a release. I think it should Just Work, but let me know if there are issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically updating the FSPS submodule
Maintainers should close and then re-open this PR to get the tests to run.