Skip to content

Fixed converting tables with rowspan and colspan#33

Merged
dfop02 merged 2 commits intodfop02:release/1.0.10from
hxzrx:main
Aug 15, 2025
Merged

Fixed converting tables with rowspan and colspan#33
dfop02 merged 2 commits intodfop02:release/1.0.10from
hxzrx:main

Conversation

@hxzrx
Copy link
Copy Markdown

@hxzrx hxzrx commented Aug 11, 2025

Description

When I was converting my html doc, the program crashed, I found that the unit failed to be parsed and the table with rowspan and colspan could not be converted, and this pr fixed the problems.

Issue Reference

None.

Checklist Before Requesting a Review

  • I have performed a self-review of my code.
  • My code follows the project's coding style and guidelines.
  • I have run tests and verified that all existing and new tests pass.
  • I have added new tests to cover my changes.

@dfop02 dfop02 self-requested a review August 11, 2025 16:08
@dfop02 dfop02 self-assigned this Aug 11, 2025
@dfop02 dfop02 added the bug Something isn't working label Aug 11, 2025
@dfop02
Copy link
Copy Markdown
Owner

dfop02 commented Aug 11, 2025

Hi @hxzrx ! Thanks for you contribution! I'll review your PR soon and return a feedback!

@dfop02 dfop02 changed the base branch from main to release/1.0.10 August 13, 2025 14:10
Copy link
Copy Markdown
Owner

@dfop02 dfop02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@dfop02 dfop02 merged commit a3d9e29 into dfop02:release/1.0.10 Aug 15, 2025
5 checks passed
@dfop02
Copy link
Copy Markdown
Owner

dfop02 commented Aug 15, 2025

@hxzrx merged! I'm just waiting the issue resolution to publish a new release, thanks for your support again :)

@dfop02 dfop02 mentioned this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants