removes annoying warning#34
Merged
bast merged 1 commit intodftlibs:masterfrom May 6, 2019
scemama:patch-1
Merged
Conversation
```
[ 31%] Building CXX object numgrid/CMakeFiles/numgrid-objects.dir/lebedev/sphere_lebedev_rule.cpp.o
/home/scemama/Downloads/numgrid/numgrid/lebedev/sphere_lebedev_rule.cpp: In function ‘void timestamp()’:
/home/scemama/Downloads/numgrid/numgrid/lebedev/sphere_lebedev_rule.cpp:6483:10: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
size_t len;
^~~
```
Member
|
Thanks! I am just waiting for restarted CI to finish and then I will merge. Sorry for all the ugly code in there :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling, I get a warning:
len can be used to check that there was no overflow, and this removes the warning.
Labels:
Description
lenis now used to check that the buffer was large enough.Motivation and Context
Warnings are very annoying for users
How Has This Been Tested?
The code was installed, compiled with no warning and the cpp_test program has been run.
Screenshots (if appropriate):
None
Todos
Nothing.
Types of changes
Questions
Status