Skip to content

Rename one CMake option #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

Rename one CMake option #105

merged 1 commit into from
Jan 21, 2020

Conversation

@robertodr
Copy link
Contributor

@robertodr robertodr commented Jan 21, 2020

Avoids possible namespace collisions when using XCFun via FetchContent

Status

  • Ready to go

@robertodr
Rename one CMake option
09d3b3f 
Avoids possible namespace collisions when using XCFun via FetchContent
@robertodr robertodr requested a review from bast January 21, 2020 09:00
@bast
Copy link
Member

bast commented Jan 21, 2020

For more context: we have seen a name collision within LSDalton.

@bast bast merged commit 023ca3a into dftlibs:master Jan 21, 2020
@bast
Copy link
Member

bast commented Jan 21, 2020

Thanks!

@robertodr robertodr deleted the rename-pybind11-option branch January 21, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bast bast Awaiting requested review from bast

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertodr @bast