Skip to content

Conversation

@robertodr
Copy link
Contributor

Heed compiler warnings and silence them.

Close #90

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Status

  • Ready to go

@robertodr robertodr requested a review from stigrj April 7, 2020 17:23
@robertodr robertodr requested a review from bast April 7, 2020 17:25
Copy link
Contributor

@stigrj stigrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet relief!

@robertodr
Copy link
Contributor Author

Sweet relief!

Not quite. Clang builds are failing and emit other warnings.

@robertodr
Copy link
Contributor Author

Clang is now also silent. I have further tested with Intel 2018 that compilatiton goes smoothly. This is good to go (for real this time).

@bast bast merged commit 4614fe5 into dftlibs:master Apr 8, 2020
@bast
Copy link
Member

bast commented Apr 8, 2020

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XCFun emits a ton of warnings

3 participants