Skip to content

Fix (SkipPredicate OR False) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ticosax wants to merge 2 commits into from
Closed

Fix (SkipPredicate OR False) #24

ticosax wants to merge 2 commits into from

Conversation

@ticosax
Copy link
Contributor

@ticosax ticosax commented Jun 16, 2015

Better SkipPredicate implementation.

Do not try to default on True or False, just ignore completely the result of the predicate if it raise SkipPredicate.

ticosax added 2 commits June 16, 2015 12:52
@ticosax
Better Skip implementation.
e7174da 
Do not try to default on True or False, just ignore completely the result
of the predicate if it raise SkipPredicate.
@ticosax
ignore .tox folder
fc84c6f
@dfunckt
Copy link
Owner

dfunckt commented Jun 19, 2015

Merged in 03ae13a. Great work @ticosax, thanks!

@dfunckt dfunckt closed this Jun 19, 2015
@ticosax
Copy link
Contributor Author

ticosax commented Jun 22, 2015

thanks

@ticosax ticosax deleted the fix-skip-with-false branch June 22, 2015 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ticosax @dfunckt