Open
Conversation
…ects- no hard-coded html elements- allow multiple managers to co-exist
Class.prototype should be an object whose prototype is Super.prototype, but _without_ calling Super. Super's constuctor should be called from Class' constructor on each object creation.
Files had mixed LF and CRLF endings, the standard git way is to use LF in the repo, git automatically converts to CRLF on windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this awesome visualization library!
This PR implements various improvemens to the code, eg improves the OO structure, removes global variables, allows classes to exist in the same page, etc. The functionality remains exactly the same, and all html pages work as before.
The purpose of these changes is to allow the code to be reused in other contexts, and in particular in my reveal.js plugin, for embeding the visualizations in lecture slides.