Skip to content

Add get_normals() public function#29

Merged
dgaylo merged 6 commits into
masterfrom
add-get_normals
Jul 29, 2025
Merged

Add get_normals() public function#29
dgaylo merged 6 commits into
masterfrom
add-get_normals

Conversation

@dgaylo

@dgaylo dgaylo commented Jul 29, 2025

Copy link
Copy Markdown
Owner

Closes #27

Changes

  • Rename reconstruction to plic
  • Add plic.get_normals() to get sign of normals
  • Refactor of testing of normals calculation
  • Documentation updates

@github-actions

Copy link
Copy Markdown

Benchmark Results


-------------------------------------------------------------------------------- benchmark 'test_bench_Chan': 2 tests -------------------------------------------------------------------------------
Name (time in us)               Min                 Max                Mean             StdDev              Median                IQR            Outliers  OPS (Kops/s)            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_Chan (head)     570.0880 (1.0)      992.6720 (1.03)     596.9985 (1.0)      24.4466 (1.05)     594.7450 (1.0)      17.1843 (1.0)        117;86        1.6750 (1.0)        1761           1
test_bench_Chan (base)     573.7980 (1.01)     959.9370 (1.0)      603.4186 (1.01)     23.2095 (1.0)      601.2890 (1.01)     18.7297 (1.09)       207;80        1.6572 (0.99)       1755           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------- benchmark 'test_bench_WY': 2 tests ------------------------------------------------------------------------
Name (time in ms)           Min               Max              Mean            StdDev            Median               IQR            Outliers       OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_WY (base)     3.3938 (1.0)      4.6874 (1.21)     3.4564 (1.0)      0.0892 (1.47)     3.4399 (1.0)      0.0450 (1.08)        16;19  289.3145 (1.0)         298           1
test_bench_WY (head)     3.4005 (1.00)     3.8890 (1.0)      3.4621 (1.00)     0.0609 (1.0)      3.4483 (1.00)     0.0419 (1.0)         25;18  288.8419 (1.00)        294           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------- benchmark 'test_bench_base': 2 tests ------------------------------------------------------------------------
Name (time in ms)             Min               Max              Mean            StdDev            Median               IQR            Outliers       OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_base (head)     1.4228 (1.0)      2.3883 (1.06)     1.4728 (1.0)      0.1269 (1.0)      1.4455 (1.0)      0.0196 (1.0)         27;61  678.9813 (1.0)         703           1
test_bench_base (base)     1.4247 (1.00)     2.2622 (1.0)      1.5067 (1.02)     0.1668 (1.31)     1.4543 (1.01)     0.0259 (1.32)        56;84  663.7129 (0.98)        700           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------------- benchmark 'test_bench_no_norm': 2 tests --------------------------------------------------------------------------------
Name (time in us)                  Min                 Max                Mean             StdDev              Median                IQR            Outliers  OPS (Kops/s)            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_bench_no_norm (base)     335.6450 (1.0)      700.0730 (1.08)     359.0165 (1.00)     24.3477 (1.0)      354.1290 (1.02)     18.7808 (1.05)      198;114        2.7854 (1.00)       2965           1
test_bench_no_norm (head)     335.8800 (1.00)     648.3070 (1.0)      358.8274 (1.0)      37.3770 (1.54)     348.4035 (1.0)      17.8785 (1.0)       138;166        2.7869 (1.0)        2976           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@dgaylo dgaylo merged commit 545df57 into master Jul 29, 2025
18 checks passed
@dgaylo dgaylo deleted the add-get_normals branch July 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create get_normals, a public interface for calculating normals.

1 participant