Skip to content

if the slot is a partial, pass the arguments#12

Merged
dgovil merged 1 commit intodgovil:masterfrom
jacobfeder:master
Oct 28, 2020
Merged

if the slot is a partial, pass the arguments#12
dgovil merged 1 commit intodgovil:masterfrom
jacobfeder:master

Conversation

@jacobfeder
Copy link
Copy Markdown
Contributor

Hi,
@dgovil I'm not 100% sure, but it looks like you need to pass the arguments if the slot is a partial. This fixed the issue I was having. Let me know if you think it's correct. If so, can you please make a minor bugfix tag as well so it can get updated in conda-forge. I have a downstream package that relies on it.

Thanks!

@dgovil dgovil merged commit a3a7674 into dgovil:master Oct 28, 2020
@dgovil
Copy link
Copy Markdown
Owner

dgovil commented Oct 28, 2020

Hi I think you're right. I'll merge this in and make a new tag here. Cheers

@dgovil
Copy link
Copy Markdown
Owner

dgovil commented Oct 28, 2020

Made a 1.1 tag

@mtsolmn
Copy link
Copy Markdown

mtsolmn commented Oct 30, 2020

Hi @dgovil Thanks for the quick merge. I maintain the feedstock on conda-forge for pysignal and publish this most current version. However, the version numbers are a little messed up at moment. Both conda-forge and PyPI are at version 1.1.1 from 1/5/1017. You've tagged this merge as 1.1.
Additionally, PySignal.py has __version__ = "1.1.3". If you could update this to say, __version__ = "1.1.4" and similarly tag the up-to-date version on GitHub has 1.1.4, I can get a new version published on conda-forge.
Thanks!

@dgovil
Copy link
Copy Markdown
Owner

dgovil commented Oct 30, 2020

@mtsolmn Done! Thanks for catching that. https://github.com/dgovil/PySignal/releases/tag/1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants