if the slot is a partial, pass the arguments#12
Merged
dgovil merged 1 commit intodgovil:masterfrom Oct 28, 2020
jacobfeder:master
Merged
if the slot is a partial, pass the arguments#12dgovil merged 1 commit intodgovil:masterfrom jacobfeder:master
dgovil merged 1 commit intodgovil:masterfrom
jacobfeder:master
Conversation
Owner
|
Hi I think you're right. I'll merge this in and make a new tag here. Cheers |
Owner
|
Made a 1.1 tag |
|
Hi @dgovil Thanks for the quick merge. I maintain the feedstock on conda-forge for pysignal and publish this most current version. However, the version numbers are a little messed up at moment. Both conda-forge and PyPI are at version 1.1.1 from 1/5/1017. You've tagged this merge as 1.1. |
Owner
|
@mtsolmn Done! Thanks for catching that. https://github.com/dgovil/PySignal/releases/tag/1.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
@dgovil I'm not 100% sure, but it looks like you need to pass the arguments if the slot is a partial. This fixed the issue I was having. Let me know if you think it's correct. If so, can you please make a minor bugfix tag as well so it can get updated in conda-forge. I have a downstream package that relies on it.
Thanks!