Add memory usage by RocksDB in checkMemoryUsage

[ashwin95r]

This change is

[coveralls]

Coverage decreased (-0.2%) to 52.39% when pulling 12b3a61 on feature/rocksmem into dd7badb on develop.

[manishrjain]

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

posting/lists.go, line 175 [r1] (raw file):

}

func checkMemoryUsage(stores []*store.Store) {

This feels a bit ugly approach. Try to avoid having to generate a list of store pointers.

---

Comments from Reviewable

[ashwin95r]

Review status: 2 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

posting/lists.go, line 175 [r1] (raw file):

Previously, manishrjain (Manish R Jain) wrote…

This feels a bit ugly approach. Try to avoid having to generate a list of store pointers.

Modified the way the stores are passed as discussed.

---

Comments from Reviewable

[manishrjain]

Looks much better now!

---

Reviewed 5 of 10 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[manishrjain]

---

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[ashwin95r]

Merged to develop with commit 487420a