Skip to content

Conversation

@ashwin95r
Copy link
Contributor

@ashwin95r ashwin95r commented Aug 17, 2016

This change is Reviewable

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage increased (+0.05%) to 50.832% when pulling e696652 on feature/improve-response into 0a5208b on master.

@manishrjain
Copy link
Contributor

:lgtm: Nice and easy! Can you add a task for yourself to test that the results look good before release?


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@ashwin95r
Copy link
Contributor Author

Yeah, checked it with some queries.
Before the change:

$ curl localhost:8082/query -XPOST -d '{
  me(_xid_: alice-in-wonderland) {
author{name}
  }
}'
{"me":[{"author":[{"name":"aswewesd"},{"name":"Lewis Carroll"}]}]}

After:

$ curl localhost:8082/query -XPOST -d '{
  me(_xid_: alice-in-wonderland) {              
author{name}
  }
}'
{"me":{"author":[{"name":"aswewesd"},{"name":"Lewis Carroll"}]}}

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@manishrjain
Copy link
Contributor

:lgtm: Awesome!


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@ashwin95r ashwin95r merged commit e696652 into master Aug 23, 2016
@pawanrawal pawanrawal deleted the feature/improve-response branch August 30, 2016 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants