Skip to content

Change Export to return Status and use simpler request #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srfrog merged 1 commit into from
Nov 8, 2018
Merged

Change Export to return Status and use simpler request #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions protos/pb.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,22 +367,6 @@ message MovePredicatePayload {
MembershipState state = 4;
}

// ExportPayload is used both as a request and a response.
// When used in request, groups represents the list of groups that need to be backed up.
// When used in response, groups represent the list of groups that were backed up.
message ExportPayload {
enum Status {
NONE = 0;
SUCCESS = 1;
DUPLICATE = 2;
FAILED = 3;
}
uint32 group_id = 1; // Group id to back up.
Status status = 2;
uint64 read_ts = 3;
int64 unix_ts = 4;
}

message TxnStatus {
uint64 start_ts = 1;
uint64 commit_ts = 2;
Expand Down Expand Up @@ -427,14 +411,14 @@ service Zero {

service Worker {
// Data serving RPCs.
rpc Mutate (Mutations) returns (api.TxnContext) {}
rpc ServeTask (Query) returns (Result) {}
rpc StreamSnapshot (stream Snapshot) returns (stream KVS) {}
rpc Sort (SortMessage) returns (SortResult) {}
rpc Schema (SchemaRequest) returns (SchemaResult) {}
rpc PurgeTs (api.Payload) returns (Num) {}
rpc Mutate (Mutations) returns (api.TxnContext) {}
rpc ServeTask (Query) returns (Result) {}
rpc StreamSnapshot (stream Snapshot) returns (stream KVS) {}
rpc Sort (SortMessage) returns (SortResult) {}
rpc Schema (SchemaRequest) returns (SchemaResult) {}
rpc PurgeTs (api.Payload) returns (Num) {}
rpc Backup (BackupRequest) returns (Status) {}
rpc Export (ExportPayload) returns (ExportPayload) {}
rpc Export (ExportRequest) returns (Status) {}
rpc ReceivePredicate(stream KVS) returns (api.Payload) {}
rpc MovePredicate(MovePredicatePayload) returns (api.Payload) {}
}
Expand All @@ -458,7 +442,7 @@ message SnapshotMeta {
}

// Status describes a general status response.
// code: 0 = success, -1 = unknown failure
// code: 0 = success, 0 != failure.
message Status {
int32 code = 1;
string msg = 2;
Expand All @@ -471,4 +455,10 @@ message BackupRequest {
string target = 4;
}

message ExportRequest {
uint32 group_id = 1; // Group id to back up.
uint64 read_ts = 2;
int64 unix_ts = 3;
}

// vim: noexpandtab sw=2 ts=2
Loading