Improve reporting of aborts and retries during live load.

[codexnull]

Summary of changes:

• Fix detection of aborts.
• Report abort and eventual success.

---

This change is 

[martinmr]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @codexnull and @manishrjain)

---

dgraph/cmd/live/batch.go, line 82 at r1 (raw file):

	start time.Time

	nreqs    uint64

not sure what nreqs is just by looking at it. does it stand for "number of requests"? If so, maybe numReqs is better.

---

dgraph/cmd/live/batch.go, line 130 at r1 (raw file):

// the node certificate is created the name much match the request host name. e.g., localhost not
// 127.0.0.1.
func handleError(err error, nreq uint64, isRetry bool) {

nit: I think reqNum is a slightly better name.

Same for all the other instances of this variable name.

[codexnull]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

---

dgraph/cmd/live/batch.go, line 82 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

not sure what nreqs is just by looking at it. does it stand for "number of requests"? If so, maybe numReqs is better.

Done.

[manishrjain]

Defer to @martinmr for review.

[martinmr]

just one comment about naming.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @codexnull)

---

dgraph/cmd/live/batch.go, line 196 at r2 (raw file):

	defer l.requestsWg.Done()
	for req := range l.reqs {
		nreq := atomic.AddUint64(&l.reqNum, 1)

Should this also be called reqNum to match the variable inside the loader? Same for all other instances of nreq.

[codexnull]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @martinmr)

---

dgraph/cmd/live/batch.go, line 196 at r2 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

Should this also be called reqNum to match the variable inside the loader? Same for all other instances of nreq.

Yes. Fixed.

[martinmr]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved