[Upsert #3] Add support for parsing functions in RDF (#3412)#3539
[Upsert #3] Add support for parsing functions in RDF (#3412)#3539mangalaman93 wants to merge 1 commit intomasterfrom
Conversation
martinmr
left a comment
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93 and @manishrjain)
chunker/rdf/parse_test.go, line 942 at r1 (raw file):
}, expectedErr: false, },
I would add more tests were expectedErr is true just in case.
Following are now possible (useful in upsert API) * uid(v) <predicate> "object" . * <0x01> <predicate> uid(foo) . For now, we only support uid function. In future, we can add support for more functions.
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
chunker/rdf/parse_test.go, line 942 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
I would add more tests were expectedErr is true just in case.
Done.
mangalaman93
force-pushed
the
aman/rdf_parser
branch
from
dedeacd to
93a3d79
Compare
martinmr
left a comment
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
|
Closing this PR for #3412 , addressed all the comments. |
2 participants
Following are now possible (useful in upsert API)
For now, we only support uid function. In future, we can
add support for more functions, starting with
val.This change is