Skip to content

Handle non-list UIDs predicates in bulk loader.#3659

Merged
martinmr merged 1 commit intomasterfrom
martinmr/single-uid-bulk-warning
Jul 17, 2019
Merged

Handle non-list UIDs predicates in bulk loader.#3659
martinmr merged 1 commit intomasterfrom
martinmr/single-uid-bulk-warning

Conversation

@martinmr
Copy link
Copy Markdown
Contributor

@martinmr martinmr commented Jul 12, 2019

If more than one uid is found in the list for a non-list predicate,
print a warning and force the predicate to be a list to avoid data-loss.
The user is responsible for fixing the situation once Dgraph is up and
running.

Fixes #3656


This change is Reviewable

If more than one uid is found in the list for a non-list predicate,
print a warning and force the predicate to be a list to avoid data-loss.
The user is responsible for fixing the situation once Dgraph is up and
running.
@martinmr martinmr requested a review from manishrjain as a code owner July 12, 2019 02:00
@martinmr martinmr requested a review from a team July 12, 2019 02:00
@martinmr martinmr changed the title Handled non-list UIDs predicates in bulk loader. Handle non-list UIDs predicates in bulk loader. Jul 12, 2019
@martinmr martinmr added this to the Dgraph v1.1 milestone Jul 12, 2019
Copy link
Copy Markdown
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 05eec27 into master Jul 17, 2019
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
If more than one uid is found in the list for a non-list predicate,
print a warning and force the predicate to be a list to avoid data-loss.
The user is responsible for fixing the situation once Dgraph is up and
running.
@joshua-goldstein joshua-goldstein deleted the martinmr/single-uid-bulk-warning branch August 11, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bulk loader should respect single UID schemas

2 participants