Skip to content

Edit test cases to remove flaky behavior#5464

Merged
all-seeing-code merged 1 commit intomasterfrom
anurags92/KshortestPathTestFix
May 19, 2020
Merged

Edit test cases to remove flaky behavior#5464
all-seeing-code merged 1 commit intomasterfrom
anurags92/KshortestPathTestFix

Conversation

@all-seeing-code
Copy link
Copy Markdown
Contributor

@all-seeing-code all-seeing-code commented May 18, 2020

This PR edits test cases to remove non-deterministic behavior in shortest path queries when there are more than one paths with identical cost.

This change is Reviewable

Copy link
Copy Markdown
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)

Copy link
Copy Markdown
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Hoping that you verified by running these tests a few times in a loop to ensure they aren't flaky anymore.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@all-seeing-code all-seeing-code merged commit bae2b1b into master May 19, 2020
all-seeing-code added a commit that referenced this pull request May 29, 2020
all-seeing-code added a commit that referenced this pull request Jun 8, 2020
all-seeing-code added a commit that referenced this pull request Jun 9, 2020
…5596)

* K-Shortest path query fix (#5410)

* Bug fix for depth parameter
* Handle cycles in K - Shortest path queries

(cherry picked from commit 6332254)

* Edit test cases to remove flaky behavior (#5464)


(cherry picked from commit bae2b1b)

* Added details of Shortest path queries in documentation (#5533)


(cherry picked from commit abb57c0)
all-seeing-code added a commit that referenced this pull request Jun 9, 2020
…5548)

* K-Shortest path query fix (#5410)

* Bug fix for depth parameter
* Handle cycles in K - Shortest path queries

(cherry picked from commit 6332254)

* Edit test cases to remove flaky behavior (#5464)


(cherry picked from commit bae2b1b)

* Added details of Shortest path queries in documentation (#5533)


(cherry picked from commit abb57c0)
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@all-seeing-code all-seeing-code deleted the anurags92/KshortestPathTestFix branch September 24, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants