Edit test cases to remove flaky behavior#5464
Merged
all-seeing-code merged 1 commit intomasterfrom May 19, 2020
Merged
Conversation
martinmr
approved these changes
May 18, 2020
Contributor
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)
pawanrawal
approved these changes
May 19, 2020
Contributor
pawanrawal
left a comment
There was a problem hiding this comment.
Hoping that you verified by running these tests a few times in a loop to ensure they aren't flaky anymore.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
all-seeing-code
added a commit
that referenced
this pull request
May 29, 2020
(cherry picked from commit bae2b1b)
all-seeing-code
added a commit
that referenced
this pull request
Jun 8, 2020
(cherry picked from commit bae2b1b)
all-seeing-code
added a commit
that referenced
this pull request
Jun 9, 2020
…5596) * K-Shortest path query fix (#5410) * Bug fix for depth parameter * Handle cycles in K - Shortest path queries (cherry picked from commit 6332254) * Edit test cases to remove flaky behavior (#5464) (cherry picked from commit bae2b1b) * Added details of Shortest path queries in documentation (#5533) (cherry picked from commit abb57c0)
all-seeing-code
added a commit
that referenced
this pull request
Jun 9, 2020
…5548) * K-Shortest path query fix (#5410) * Bug fix for depth parameter * Handle cycles in K - Shortest path queries (cherry picked from commit 6332254) * Edit test cases to remove flaky behavior (#5464) (cherry picked from commit bae2b1b) * Added details of Shortest path queries in documentation (#5533) (cherry picked from commit abb57c0)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR edits test cases to remove non-deterministic behavior in shortest path queries when there are more than one paths with identical cost.
This change is