fix(Export/Import): Live load exported schema#5696
Merged
danielmai merged 1 commit intorelease/v20.07from Jun 19, 2020
Merged
Conversation
This PR fixes the issue where live loader was not able to import the schema exported using export request. It does so, by allowing the alter schema request for pre-defined types to go through if the type in the request is same as the initial internal type. This issue was introduced as a result of #5185. This PR also disallows a pre-defined type from being dropped. Fixes #DGRAPH-1694. (cherry picked from commit 76ae60b)
abhimanyusinghgaur
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
github-actions
Bot
added
area/enterprise
danielmai
approved these changes
Jun 19, 2020
Contributor
danielmai
left a comment
danielmai
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where live loader was not able to import the schema exported using export request. It does so, by allowing the alter schema request for pre-defined types to go through if the type in the request is same as the initial internal type.
This issue was introduced as a result of #5185.
This PR also disallows a pre-defined type from being dropped.
Fixes #DGRAPH-1694.
This change is
Docs Preview: