Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 12, 2025

No description provided.

@ghost ghost self-requested a review June 12, 2025 14:54
@github-actions github-actions bot added area/testing Testing related issues area/core internal mechanisms go Pull requests that update Go code labels Jun 12, 2025
@RJKeevil
Copy link
Contributor

Note that github.com/golang/protobuf is deprecated, according to its page it's superceded google.golang.org/protobuf. I saw it becoming a direct dependency in this branch.

@ghost
Copy link
Author

ghost commented Jun 16, 2025

@RJKeevil Yes that's why the tests are failing. We are trying to fix that.

@mangalaman93 mangalaman93 force-pushed the harshil-goel/has-optimization branch from b887328 to f656337 Compare June 17, 2025 08:46
@trunk-io
Copy link

trunk-io bot commented Jun 17, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@ghost ghost force-pushed the harshil-goel/has-optimization branch from 6f791d4 to 28889cf Compare June 21, 2025 23:18
@ghost ghost force-pushed the harshil-goel/has-optimization branch from 28889cf to 4883980 Compare June 22, 2025 20:00
@mangalaman93 mangalaman93 enabled auto-merge (squash) June 23, 2025 13:05
@mangalaman93 mangalaman93 merged commit 104cbae into main Jun 23, 2025
14 checks passed
@mangalaman93 mangalaman93 deleted the harshil-goel/has-optimization branch June 23, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

3 participants