fix(txn): for lossy indexes, change comparison function to first check the txn cache #9567
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
shiva-istari
approved these changes
Jan 16, 2026
matthewmcneely
deleted the
matthewmcneely/fix-lossy-index-issue-in-txn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9556
This PR fixes an issue where comparison functions invoked in transactions would miss un-committed values. This change ensure the transaction cache is first searched, before resuming the old flow through posting.GetNoStore and fetchValue.
A test was also added.
Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.