Consistently refer to the right Result in macro expansion#281
Merged
dgrunwald merged 1 commit intodgrunwald:masterfrom Sep 21, 2022
Merged
Consistently refer to the right Result in macro expansion#281dgrunwald merged 1 commit intodgrunwald:masterfrom
Result in macro expansion#281dgrunwald merged 1 commit intodgrunwald:masterfrom
Conversation
Without this, importing any other crate's Result type alias in a module
that uses cpython's macros causes compilation to fail in a variety of
interesting ways.
Repro:
use cpython::{py_class, PyResult};
use std::io::Result;
py_class!(class Struct |py| {
def __new__(_cls) -> PyResult<Struct> {
Struct::create_instance(py)
}
});
The resulting diagnostic:
error[E0107]: this type alias takes 1 generic argument but 2 generic arguments were supplied
--> src/main.rs:4:1
|
4 | / py_class!(class Struct |py| {
5 | | def __new__(_cls) -> PyResult<Struct> {
6 | | Struct::create_instance(py)
7 | | }
8 | | });
| | ^
| | |
| |__expected 1 generic argument
| help: remove this generic argument
|
note: type alias defined here, with 1 generic parameter: `T`
--> nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/io/error.rs:55:10
|
55 | pub type Result<T> = result::Result<T, Error>;
| ^^^^^^ -
= note: this error originates in the macro `$crate::py_class_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, importing any other crate's
Resulttype alias in a module that uses cpython's macros causes compilation to fail in a variety of interesting ways.Repro:
The resulting diagnostic: