Pick THREAT call format from on-frequency receivers#656
Merged
Conversation
dharmab
force-pushed
the
threat-call-receiver-format
branch
2 times, most recently
from
8b5756b to
1fb963c
Compare
Closes #654. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dharmab
force-pushed
the
threat-call-receiver-format
branch
from
1fb963c to
304952e
Compare
| // receivers' BRAAs to a hostile. If the spread is within this threshold, | ||
| // the individual BRAA calls can be merged into a single call using the | ||
| // receivers' geographic midpoint. | ||
| const maxSharedBRAABearingSpread = 5 * unit.Degree |
There was a problem hiding this comment.
Consider allowing the end user to set this value, allows for better customisation and theatre fit.
| // receivers' BRAAs to a hostile. If the spread is within this threshold, | ||
| // the individual BRAA calls can be merged into a single call using the | ||
| // receivers' geographic midpoint. | ||
| const maxSharedBRAARangeSpread = 1 * unit.NauticalMile |
There was a problem hiding this comment.
Consider allowing the end user to set this value, allows for better customisation and theatre fit.
WigglySuperNoodle
suggested changes
Apr 23, 2026
WigglySuperNoodle
left a comment
WigglySuperNoodle
left a comment
There was a problem hiding this comment.
The logic changes look to be solid.
If possible, it would be good for the end user (server admin) to be able to specify the constants as per my comments on threat.go lines 20 and 26.
Add --threat-braa-bearing-spread and --threat-braa-range-spread flags so server admins can tune when threat calls use BRAA vs bullseye format based on their theatre and player density. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #654.
Summary
radar.Threatsnow filters the receiver set to friendlies on the controller's SRS frequency before deciding the call format, so AI wingmen and off-frequency friendlies no longer inflate the count.radar.Newtakes a*simpleradio.Clientfor checking who's on frequency.broadcastThreattrusts the filtered map and no longer checks frequency.bearings.AngularDistancefor wrap-around-safe bearing differences.