Fix callsign index collisions and stale entries#676
Merged
Conversation
Index on raw contact names instead of normalized callsigns, and normalize at lookup time. This fixes two bugs: normalized names colliding (e.g. [ABC]Viper11 and [XYZ]Viper11 overwriting each other) and delete() using raw names against normalized keys (leaving ghost index entries). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #659
callsignIdxon rawContact.Nameinstead of normalized callsigns, preventing collisions when multiple contacts normalize to the same key (e.g.[ABC]Viper 1-1and[XYZ]Viper 1-1)delete()now correctly removes index entries since it already uses raw names as keysParsePilotCallsignmoved to lookup time ingetByCallsignAndCoalititon— benchmarked at ~37-47µs with 40 contacts on Apple M4🤖 Generated with Claude Code