Fix/failing tests#613
Open
ArisOIKON wants to merge 2 commits into
Open
Conversation
|
coverage: 88.719%. remained the same — ArisOIKON:fix/failing-tests into dhatim:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
CorrectnessTest.testForOffBy1ErrorFor1900_utilDatewhichfails on non-UTC timezones (e.g. UTC+2, UTC+3, etc).
Root Cause
The test asserted hardcoded Excel serial numbers (e.g. 1.0, 367.0)
against
convertDate(Date), which explicitly uses the systemtimezone by design (as documented in its Javadoc). On non-UTC
machines, midnight in the local timezone converts to a fractional
serial number rather than a whole number.
Fix
Instead of asserting hardcoded values (1.0, 367.0), the test now verifies that
convertDate(Date) is consistent with convertDate(LocalDate)
using the same system timezone (what the method actually
guarantees).
Testing
Verified passing on UTC+3 (Greece) where the test previously failed. All testing is now succesful.