Call cleanup in callback and error handler instead of finally block.#665
Merged
Conversation
…the finally block to address another part of dherault#659
Owner
|
Thanks @Andorbal, v4.10.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the second part of #659 where cleanup wasn't getting called properly for callback based requests that deferred execution.
I'm not sure what the original intent of the cleanup method was and this feels a bit like whack-a-mole. That said, all tests pass (including two new ones) and the test application linked in the issue works correctly. Speaking of tests, I have one test around error handling and I'm not sure how to suppress logging of the error to the screen while running the tests. Not sure if that matters, but it doesn't look nice.