Codereview#33
Merged
Merged
Conversation
…uthentication - Implement Auth0 OIDC (SSO) admin login, enabling secure SSO for admin users. - Support both Auth0 OIDC and legacy password login simultaneously (feature-flagged by config). - Enforce email allowlisting for admin login via new `ADMIN_LOGIN_EMAILS` config. - Add/extend design, feature spec, and implementation docs to cover dual-mode auth, state/cookie security, and backward compatibility. - Update and add tests for SSO and password fallback scenarios. - Review notes added under `docs_v2/09_Reviews/020_auth0_login_review.md`. Backward compatible: deployments without Auth0 config continue to use password-only admin login. See feature documentation for setup and migration instructions.
- Add Auth0 OIDC (SSO) login option while retaining legacy password logic - Update session, cookie, and admin protection flows for robust security and flexibility - Backward compatible: deployments without Auth0 continue to work - Expanded/updated tests for new flows and endpoints (incl. integration) Also: - Move sidecar and caption logic to new `services/sidecar.py` - Refactor workflow and web glue for clean sidecar/caption handling - Update endpoint handlers and e2e tests for new auth/session logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue
Fixes #(issue number)
Changes Made
Testing
[ ] Tested manually with the following scenarios:
Security Considerations
Checklist
Screenshots (if applicable)
Additional Notes