Feature/captionfile#4
Merged
Merged
Conversation
…rchive sidecar move
…ption and sidecar
…or sd caption sidecar
…egration test for compatibility
…eview (no side effects)
…integration test to avoid preview duplicate exit
…onal fields; expand OpenAI prompt and strict JSON mapping; update preview to display new fields; add unit and e2e tests (parsing, preview, error paths); update AI prompts reference and mark feature request Implemented
Add CaptionFileConfig with [CaptionFile] extended_metadata_enabled flag (default: false) and load via config loader. Add DropboxStorage.get_file_metadata(folder, filename) to fetch id/rev for identity/version metadata. Add utils.captions builders: build_metadata_phase1/phase2 and build_caption_sidecar to produce first-line sd_caption + YAML-like comment block (keys, JSON arrays). Integrate in WorkflowOrchestrator: compose sidecar content with identity/version (Phase 1) and optional contextual metadata (Phase 2 flag), write in normal runs only (no-op in preview/dry/debug). Preview: add print_caption_sidecar_preview and wire in app preview to display full sidecar content. Docs: update configuration and SD caption file docs with format, separator, and flag; add new feature request and plan (ID 004). Tests: add unit tests for sidecar builders and e2e test validating Phase 1/2 fields; all pass locally. Perf: sidecar write O(1); small payload; target P95 ≤ 10ms. Security/Compliance: no secrets; PG-13 contextual metadata only; backward-compatible (training-safe first line). Feature-ID: 004 caption-file-extended-metadata
- Use datetime.now(timezone.utc) in app.py, core/workflow.py, utils/logging.py - Preserve 'Z' suffix where previously used to maintain output compat - Removes DeprecationWarning; keeps Python 3.9+ compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue
Fixes #(issue number)
Changes Made
Testing
[ ] Tested manually with the following scenarios:
Security Considerations
Checklist
Screenshots (if applicable)
Additional Notes