fix: move from cli-style to shared configs#1434
Merged
Conversation
kabaros
force-pushed
the
use-style-configs
branch
10 times, most recently
from
9592ade to
c8b1d86
Compare
kabaros
changed the title
kabaros
force-pushed
the
use-style-configs
branch
4 times, most recently
from
aa92ab5 to
70128f1
Compare
kabaros
changed the title
kabaros
force-pushed
the
use-style-configs
branch
2 times, most recently
from
70128f1 to
2044257
Compare
kabaros
changed the title
kabaros
force-pushed
the
use-style-configs
branch
4 times, most recently
from
24ebd01 to
a824729
Compare
kabaros
force-pushed
the
use-style-configs
branch
from
a824729 to
36b4dc1
Compare
|
kabaros
changed the title
kabaros
changed the title
| "docs:serve": "d2-utils-docsite serve ./docs -o ./dist", | ||
| "lint": "d2-style check js && d2-style check text" | ||
| "lint": "eslint && prettier -c .", | ||
| "prepare": "husky" |
Contributor
There was a problem hiding this comment.
Figure out what this does? 😁
Contributor
Author
There was a problem hiding this comment.
confirmed this is a lifecycle method that would initialise husky (on yarn install)
Comment on lines
+33
to
+39
| - run: yarn add -W @commitlint/config-conventional@13 | ||
| - id: commitlint | ||
| run: echo ::set-output name=config_path::$(node -e "process.stdout.write(require('@dhis2/cli-style').config.commitlint)") | ||
| run: | | ||
| curl https://raw.githubusercontent.com/dhis2/cli-style/refs/heads/master/config/commitlint.config.js -o commitlint.config.js | ||
| echo ::set-output name=config_path::commitlint.config.js | ||
| - run: echo ${{ steps.commitlint.outputs.config_path }} | ||
| - run: cat ${{ steps.commitlint.outputs.config_path }} |
Contributor
There was a problem hiding this comment.
Just a note to self: this can become a one-liner when commit-lint is added to shared configs;
Nice to do the same for PR title lint
Contributor
Author
There was a problem hiding this comment.
added a comment about it to the revamp epic
KaiVandivier
approved these changes
Apr 15, 2026
dhis2-bot
added a commit
that referenced
this pull request
Apr 15, 2026
# [3.17.0-beta.3](v3.17.0-beta.2...v3.17.0-beta.3) (2026-04-15) ### Bug Fixes * move from cli-style to shared configs ([#1434](#1434)) ([9a08180](9a08180))
Contributor
|
🎉 This PR is included in version 3.17.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.