feat: add explicit support for systemInfo and serverVersion config props#652
Merged
Conversation
Contributor
|
EDIT: Just answered my questions by reading through the description of the app platform PR |
Mohammer5
approved these changes
Oct 12, 2020
dhis2-bot
added a commit
that referenced
this pull request
Oct 12, 2020
# [2.4.0](v2.3.0...v2.4.0) (2020-10-12) ### Features * add explicit support for systemInfo and serverVersion config props ([#652](#652)) ([15b8344](15b8344))
Contributor
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds typescript annotations for
systemInfoandserverVersionproperties on the Config context object.Note that these are currently added as Optional properties to avoid causing a breaking change, but eventually we will want them to be required.