feat(release): support distribution tags and custom release user info#292
Merged
feat(release): support distribution tags and custom release user info#292
Conversation
varl
commented
Mar 12, 2020
Comment on lines
-14
to
-15
| const fs = require('fs') | ||
| const chalk = require('chalk') |
varl
commented
Mar 12, 2020
| }) => { | ||
| for (const language in translations) { | ||
| if (translations.hasOwnProperty(language)) { | ||
| if (Object.prototype.hasOwnProperty.call(translations, language)) { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no access to prototype built-ins
varl
commented
Mar 12, 2020
Comment on lines
-19
to
+20
| const filePathToDelete = path.join(inDir, file) | ||
| const filePathToDelete = file |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no undefined variables
varl
commented
Mar 12, 2020
| } | ||
|
|
||
| const rest = await tryCatchAsync( | ||
| const res = await tryCatchAsync( |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
Also a bug where res is accessed later, but the variable is named rest.
varl
commented
Mar 12, 2020
| await Promise.all( | ||
| clusters.map(async cluster => { | ||
| const status = await getStatus(cluster) | ||
| cluster.status = formatStatus(status) |
Contributor
Author
There was a problem hiding this comment.
Lint rule: possible race condition (mutating source while looping)
varl
commented
Mar 12, 2020
| } | ||
| } | ||
|
|
||
| const restoreFromFile = async ({ cacheLocation, dbFile, dbVersion, name }) => { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
varl
commented
Mar 12, 2020
| const { reporter, chalk } = require('@dhis2/cli-helpers-engine') | ||
|
|
||
| const buildApp = async ({ name, ...argv }) => { | ||
| const buildApp = async () => { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
varl
commented
Mar 12, 2020
| type = type.toLowerCase() | ||
| switch (type) { | ||
| case 'cli': | ||
| case 'cli': { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: lexical scope needed to use const in case
varl
commented
Mar 12, 2020
| const command = { | ||
| command: 'create <type> [name]', | ||
| desc: 'Create various DHIS2 components from templates', | ||
| builder: yargs => { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
varl
commented
Mar 12, 2020
| @@ -1,4 +1,4 @@ | |||
| const run = ({ _, $0, raw, ...argv }) => { | |||
| const run = ({ raw, ...argv }) => { | |||
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
varl
commented
Mar 12, 2020
| const SemanticReleaseError = require('@semantic-release/error') | ||
|
|
||
| const analyzeCommits = (config = {}, context) => { | ||
| const analyzeCommits = (config, context) => { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: no unused variables
varl
commented
Mar 12, 2020
| } | ||
|
|
||
| validPackages.forEach(package => { | ||
| package.label = package.json.name || '<unnamed>' |
Contributor
Author
There was a problem hiding this comment.
Lint rule: package is a reserved keyword
varl
commented
Mar 12, 2020
| } | ||
|
|
||
| const replaceDependencies = (pkg, listNames, packageNames, version) => { | ||
| const replaceDependencies = ({ pkg, listNames, packageNames, version }) => { |
Contributor
Author
There was a problem hiding this comment.
Lint rule: max-params > 3
Contributor
Author
|
Added comments to the lint rule resolutions. |
Contributor
|
@varl this looks great!! (and thanks for fixing all my lint bugs) I'll take a deeper look at the code, but allowing |
Contributor
|
We could merge this to |
Contributor
Author
|
I want to see if it works, so |
Contributor
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
varl
added a commit
that referenced
this pull request
Mar 15, 2020
…#292) * feat(release): support distribution tags and custom release user info * ci(actions): add lint and test * chore(lint): resolve long-standing lint issues * ci(actions): update workflow templates Co-authored-by: Austin McGee <947888+amcgee@users.noreply.github.com>
dhis2-bot
added a commit
that referenced
this pull request
Mar 15, 2020
# [2.9.0](v2.8.1...v2.9.0) (2020-03-15) ### Bug Fixes * **release:** cannot use squash/rebase when using dist channels in semantic-release ([1f994fb](1f994fb)) * release with the internal changes, not the npm package ([2e17226](2e17226)) ### Features * **release:** support distribution tags and custom release user info ([#292](#292)) ([17496d1](17496d1))
dhis2-bot
added a commit
that referenced
this pull request
Mar 15, 2020
# [2.9.0](v2.8.1...v2.9.0) (2020-03-15) ### Bug Fixes * **release:** cannot use squash/rebase when using dist channels in semantic-release ([1f994fb](1f994fb)) * **release:** fix the changelog ([f6ca488](f6ca488)) * release with the internal changes, not the npm package ([2e17226](2e17226)) ### Features * **release:** support distribution tags and custom release user info ([#292](#292)) ([17496d1](17496d1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master,next,next-major,N.x,N.x.x,N.N.x,beta,alphanextpublishes on the dist-tag@next, more info here: https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/distribution-channels.mdN.xwhereNis a number. Thexis literal, e.g. to release a patch on version 1 create the branch1.x, for1.2create1.2.x, etc.betaandalphabranches will be marked asprerelease.GIT_*variables to be configured through the environment, previously they were hardcoded.