Skip to content

Conversation

@zubaira
Copy link
Contributor

@zubaira zubaira commented Sep 19, 2025

No description provided.

@zubaira zubaira requested a review from jbee September 19, 2025 08:11
Copy link
Collaborator

@jbee jbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes really should be discussed before starting to put effort into them.

While strong typing is generally a good thing in this case I think the flexibility and simplicity of String is beneficial and I see no reason or need to make it more complicated.
In addition, as you say, this would be a SPI breaking change. Why would we break something that as far as I can tell is capable of doing what is needed.
Being an SPI this is part of the interfacing with other languages so every complication on the type level makes it harder to use/integrate for a caller.
So I am pretty sure we want to stick to String keys.

@sonarqubecloud
Copy link

@zubaira zubaira changed the title refactor: Use SupplementaryKey instead of raw Strings Change minor version to reflect a breaking change Sep 19, 2025
@zubaira zubaira changed the title Change minor version to reflect a breaking change Change minor version to reflect a breaking change[DHIS2-19426] Sep 19, 2025
@zubaira zubaira requested a review from jbee September 19, 2025 11:42
@zubaira zubaira merged commit 5d0da48 into main Sep 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants