Conversation
Contributor
Author
|
Changed to |
dhis2-bot
pushed a commit
that referenced
this pull request
Aug 25, 2019
## [1.0.4](v1.0.3...v1.0.4) (2019-08-25) ### Bug Fixes * add react as a peer dependency ([#33](#33)) ([88cb383](88cb383))
Contributor
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
yarnis used in PnP mode it requires that all used dependencies be explicitly specified in package.json. That revealed thatprop-typesusesreactbut doesn't specify any kind of dependency onreact. Since we just useReact.ChildrenI think it's probably fine to use*as a peerDep here, but we could also specify a minimum version (16?) if we wanted to.