feat: add custom prop types to propTypes object#39
Merged
HendrikThePendric merged 3 commits intomasterfrom Sep 11, 2019
Merged
Conversation
Contributor
Author
|
Update: |
varl
approved these changes
Sep 11, 2019
Contributor
varl
left a comment
varl
left a comment
There was a problem hiding this comment.
Looks fine, we can refactor with something "prettier" later. 🙆♂️
dhis2-bot
added a commit
that referenced
this pull request
Sep 11, 2019
# [1.1.0](v1.0.4...v1.1.0) (2019-09-11) ### Features * add custom prop types to propTypes object ([#39](#39)) ([e23ffb7](e23ffb7))
Contributor
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #38, but in a slightly different way. We now only expose the default export (propTypes) and make sure our custom propTypes are attached. Let me know if you guys would prefer to also expose the individual custom prop-types here...
Fixes #38.