fix(command-palette): highlighting after search mode

[d-rita]

Fixes LIBS-756

---

Description

This PR fixes some highlighting issues after the search filter has been cleared.

1. It highlights first category item in the category view instead of the back action
2. It highlights the first item in the default section in the home view

Checklist

• API docs are generated
• Tests were added
• Storybook demos were added

---

Screenshots

Before:

list.view.-.before.mov

After:

after.-.list.view.mov

[dhis2-bot]

🚀 Deployed on https://pr-1672--dhis2-ui.netlify.app

[amcgee]

LGTM! Left one minor comment

[amcgee]

(minor) I think this logic could be cleaned up a bit so it's easier to read. For example, instead of having multiple ternary operators with the filter condition, it should be possible to just have a single if statement at the beginning. And then the remaining ternary could just be a nested if to make it a little easier to read. Something like this, maybe:

    const activeItems = useMemo(() => {
        if (filter) {
            return itemsArray;
        }
        if (currentView === HOME_VIEW) {
            if (activeSection === GRID_SECTION) {
                return itemsArray
            } else {
                return actionsArray
            }
        } else {
            return actionsArray.concat(itemsArray)
        }
    }, [filter, itemsArray, actionsArray, currentView, activeSection])

Another option would be to combine all branches which yield itemsArray in a single if statement:

    const activeItems = useMemo(() => {
        if (filter || (currentView === HOME_VIEW && activeSection === GRID_SECTION)) {
            return itemsArray;
        }
        if (currentView === HOME_VIEW) {
            return actionsArray
        } else {
            return actionsArray.concat(itemsArray)
        }
    }, [filter, itemsArray, actionsArray, currentView, activeSection])

There are likely other ways to make this a bit more readable, especially by thinking about which variables are needed and how they're named, but regardless it will help to clean up the logic in this memoized callback a bit.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud