feat(transfer): add prop selected to renderOption (TECH-393)#212
Merged
martinkrulltott merged 3 commits intomasterfrom Jul 10, 2020
Merged
feat(transfer): add prop selected to renderOption (TECH-393)#212martinkrulltott merged 3 commits intomasterfrom
martinkrulltott merged 3 commits intomasterfrom
Conversation
martinkrulltott
changed the title
Mohammer5
suggested changes
Jul 10, 2020
Contributor
Mohammer5
left a comment
Mohammer5
left a comment
There was a problem hiding this comment.
This looks good to me.
Could you add one pre-selected option to the Custom List Options story so people see the difference right away?
Contributor
Author
|
@Mohammer5, added 2 pre-selected options to the story 👍 |
Mohammer5
approved these changes
Jul 10, 2020
martinkrulltott
force-pushed
the
fix/transfer-selected-render-option
branch
from
798d6f0 to
c81317c
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Contributor
|
🎉 This PR is included in version 5.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Fixes TECH-393
Adds a
selectedprop (bool) to theTransfercomponent'srenderOption. This enables consumers to useselectedin therenderOptionfunction to provide separate styles for the source options and picked options, in addition to the already existinghighlightedprop.Story example: Custom List Options
