Skip to content

fix(transfer): pass correct selected value to renderOption#249

Merged
Mohammer5 merged 2 commits intomasterfrom
Transfer_selected_prop_not_passed_to_renderOption
Aug 20, 2020
Merged

fix(transfer): pass correct selected value to renderOption#249
Mohammer5 merged 2 commits intomasterfrom
Transfer_selected_prop_not_passed_to_renderOption

Conversation

@Mohammer5
Copy link
Copy Markdown
Contributor

Fixed #247

When adding the last couple of features, I've refactored the code and a bug snack in.
I've covered the functionality with a test so this particular bug should never appear again.

@Mohammer5 Mohammer5 requested a review from a team as a code owner August 20, 2020 14:34
@cypress
Copy link
Copy Markdown

cypress Bot commented Aug 20, 2020



Test summary

494 0 0 0


Run details

Project ui
Status Passed
Commit b9edf4f
Started Aug 20, 2020 2:58 PM
Ended Aug 20, 2020 3:10 PM
Duration 11:21 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Mohammer5 Mohammer5 force-pushed the Transfer_selected_prop_not_passed_to_renderOption branch from babb5fd to b9edf4f Compare August 20, 2020 14:56
Copy link
Copy Markdown
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mohammer5 Mohammer5 merged commit 5cc0242 into master Aug 20, 2020
@Mohammer5 Mohammer5 deleted the Transfer_selected_prop_not_passed_to_renderOption branch August 20, 2020 15:13
@dhis2-bot
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer: selected prop not provided anymore

3 participants