Conversation
ghost
marked this pull request as ready for review
Contributor
HendrikThePendric
left a comment
HendrikThePendric
left a comment
There was a problem hiding this comment.
Excellent.
Using if blocks instead of an expression here for readability,
I fully agree this was the time to move to blocks 👍
varl
approved these changes
Apr 23, 2020
Contributor
|
🎉 This PR is included in version 5.0.0-alpha.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
eirikhaugstulen
added a commit
that referenced
this pull request
Apr 13, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
eirikhaugstulen
added a commit
that referenced
this pull request
Apr 15, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the display of field specific submitErrors (see here: meta.submitError). The hasError helper is already dealing with this properly, since it looks at meta.invalid and that's triggered for validation and submission errors.
Using if blocks instead of an expression here for readability, since otherwise it got quite long and difficult to parse. Plus, this only returns the value if it's truthy, slightly different logic, but should be the same in practice (since the values should only be strings and it returns
''at the end).I noticed the forms tests aren't being run (or it seems like it): https://dhis2.slack.com/archives/CBM8LNEQM/p1587567537209200. After that's resolved I'll take a look at updating tests where necessary.
Closes #33