move asset to asset-did (similar to other pallets)#597
Open
amarts wants to merge 1 commit intodhiway:didlessfrom
Open
move asset to asset-did (similar to other pallets)#597amarts wants to merge 1 commit intodhiway:didlessfrom
amarts wants to merge 1 commit intodhiway:didlessfrom
Conversation
Signed-off-by: Amar Tumballi <amar@dhiway.com>
vatsa287
approved these changes
Mar 17, 2025
Collaborator
vatsa287
left a comment
vatsa287
left a comment
There was a problem hiding this comment.
LGTM.
If we are planning to bring this(or account based) into our runtime, we can update the name of the pallet reference from Asset to AssetDid. This would bring changes in tests, identifier, benchmarking, runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.