🐛 bug fix(cli.ts): properly handle the 'fgm' flag argument.#313
Merged
di-sukharev merged 1 commit intodi-sukharev:devfrom Mar 18, 2024
Merged
🐛 bug fix(cli.ts): properly handle the 'fgm' flag argument.#313di-sukharev merged 1 commit intodi-sukharev:devfrom
di-sukharev merged 1 commit intodi-sukharev:devfrom
Conversation
…ments to the commit function
di-sukharev
approved these changes
Mar 18, 2024
Owner
|
will be in the next patch version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the bug with the 'fgm' flag.
Current Bug
When executing the
ococommand using the--fgmflag, the value of thefgmflag is not correctly reflected. Instead,isStageAllFlagis mistakenly treated as true.Cause of the Bug
This is because, in the following commit, the order of arguments in the 'commit' function changed, but this was not reflected in the arguments at the call site.
a33027b
Changes
fgmflag argument is correctly passed to thecommands/commitfunction in theclifile.fgmflag toisStageAllFlagNote
If possible, how about handling optional arguments like this with object destructuring assignment?
When there are multiple optional arguments, you can pass only the arguments you want to pass without being aware of the order of the option keys, and it is extensible even when options increase.
Best regards