fix(githook.ts): fix SYMLINK_URL for Windows #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYMLINK_URL variable is now created using the path.join method, which is more platform-independent and ensures that the correct path separator is used. This improves the reliability of the code and makes it easier to maintain.
Contributor
|
This issue was solved in #79 and is waiting to be pulled in. |
Owner
|
@SecTex @matt-degraffenreid well.. i've merged it and macos hook started failing, so i removed separator for macos and linux and kept it for windows, lets wait when conflict in #79 is solved and merge it <3 |
zen0bit
pushed a commit
to oSoWoSo/opencommit
that referenced
this pull request
Apr 12, 2023
* fix(githook.ts): fix SYMLINK_URL for Windows * refactor(githook.ts): use path.join to create SYMLINK_URL The SYMLINK_URL variable is now created using the path.join method, which is more platform-independent and ensures that the correct path separator is used. This improves the reliability of the code and makes it easier to maintain. --------- Co-authored-by: Maik Stegemann <ms@lis-gmbh.com>
zen0bit
pushed a commit
to oSoWoSo/opencommit
that referenced
this pull request
Apr 14, 2023
* fix(githook.ts): fix SYMLINK_URL for Windows * refactor(githook.ts): use path.join to create SYMLINK_URL The SYMLINK_URL variable is now created using the path.join method, which is more platform-independent and ensures that the correct path separator is used. This improves the reliability of the code and makes it easier to maintain. --------- Co-authored-by: Maik Stegemann <ms@lis-gmbh.com>
zen0bit
pushed a commit
to oSoWoSo/opencommit
that referenced
this pull request
Apr 14, 2023
* fix(githook.ts): fix SYMLINK_URL for Windows * refactor(githook.ts): use path.join to create SYMLINK_URL The SYMLINK_URL variable is now created using the path.join method, which is more platform-independent and ensures that the correct path separator is used. This improves the reliability of the code and makes it easier to maintain. --------- Co-authored-by: Maik Stegemann <ms@lis-gmbh.com>
zen0bit
pushed a commit
to oSoWoSo/opencommit
that referenced
this pull request
Apr 14, 2023
* fix(githook.ts): fix SYMLINK_URL for Windows * refactor(githook.ts): use path.join to create SYMLINK_URL The SYMLINK_URL variable is now created using the path.join method, which is more platform-independent and ensures that the correct path separator is used. This improves the reliability of the code and makes it easier to maintain. --------- Co-authored-by: Maik Stegemann <ms@lis-gmbh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SYMLINK_URLhas been updated to fix an issue with the CLI tool that caused it to crash on Windows environments with the error message "SystemError [ERR_TTY_INIT_FAILED]: TTY initialization failed: uv_tty_init returned EBADF (bad file descriptor)".