Merged
Conversation
* unit tests do not use GitHub OIDC * Also enable workflow dispatch for easier workflow testing Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Unit tests are all mocked: makes sense to do an actual test as well. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Mainly make sure the audience is the requested one. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Add a _request() helper method.
The helper ensures query params are added to the url correctly,
avoiding the urllib3 pitfall where
urllib3.request("GET", "http://localhost:8000/?arg2=val2", fields={"arg": "val"}`
# server sees "GET /?arg2=val2?arg=val"
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
* Add tests to check audience * Also fix the existing tests so the new url building does not break them
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Collaborator
|
/gcbrun |
woodruffw
approved these changes
Feb 3, 2026
Collaborator
|
Thanks @jku! |
di
approved these changes
Feb 3, 2026
Owner
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all the improvements around audience that made sense to me: I can also try to split these up if there's disagreement.
Fixes #441
_request()helper to do what @di suggested in the bug: build the URL manually to avoid the query parameter mangling that currently happens to GitHub token request URL