DDCORE-9772 Extended DssSign #1196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuvorovNM
force-pushed
the
DDCORE-9772-ExtendDssSign
branch
2 times, most recently
from
ea52917 to
1c74acd
Compare
koheatel
approved these changes
Mar 17, 2025
src/DiadocHttpApi.CloudCrypt.cs
Outdated
| [Obsolete("Currently unavailable. Use DssSign")] | ||
| public AsyncMethodResult DssSignV2(string authToken, string boxId, DssSignRequestV2 request) | ||
| { | ||
| var queryString = new PathAndQueryBuilder("V2/DssSign"); |
Contributor
There was a problem hiding this comment.
Для однообразия с остальными методами
Suggested change
| var queryString = new PathAndQueryBuilder("V2/DssSign"); | |
| var queryString = new PathAndQueryBuilder("/V2/DssSign"); |
src/DiadocHttpApi.CloudCryptAsync.cs
Outdated
| [Obsolete("Currently unavailable. Use DssSignAsync")] | ||
| public Task<AsyncMethodResult> DssSignV2Async(string authToken, string boxId, DssSignRequestV2 request) | ||
| { | ||
| var queryString = new PathAndQueryBuilder("V2/DssSign"); |
Contributor
There was a problem hiding this comment.
Для однообразия с остальными методами
Suggested change
| var queryString = new PathAndQueryBuilder("V2/DssSign"); | |
| var queryString = new PathAndQueryBuilder("/V2/DssSign"); |
SuvorovNM
force-pushed
the
DDCORE-9772-ExtendDssSign
branch
from
c51903c to
35c6a13
Compare
added 2 commits
April 10, 2025 10:04
SuvorovNM
force-pushed
the
DDCORE-9772-ExtendDssSign
branch
from
35c6a13 to
a21da02
Compare
Contributor
Author
|
Пока решили отказаться от публикации SDK с данной фичей, закрываю PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.