fix: DLT-2878 stories using emoji row#1007
Merged
Nina Repetto (ninarepetto) merged 1 commit intostagingfrom Jan 6, 2026
Merged
fix: DLT-2878 stories using emoji row#1007Nina Repetto (ninarepetto) merged 1 commit intostagingfrom
Nina Repetto (ninarepetto) merged 1 commit intostagingfrom
Conversation
Contributor
|
✔️ Deploy previews ready! 😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-1007/ |
Nina Repetto (ninarepetto)
requested review from
Brad Paugh (braddialpad),
Francis Rupert (francisrupert) and
Ignacio Ropolo (iropolo)
as code owners
Ignacio Ropolo (iropolo)
approved these changes
Jan 6, 2026
Contributor
Ignacio Ropolo (iropolo)
left a comment
Ignacio Ropolo (iropolo)
left a comment
There was a problem hiding this comment.
this is great
Brad Paugh (braddialpad)
pushed a commit
that referenced
this pull request
Jan 6, 2026
# [3.198.0](dialtone-vue3/v3.197.3...dialtone-vue3/v3.198.0) (2026-01-06) ### Bug Fixes * DLT-2878 stories using emoji row ([#1007](#1007)) ([9f2b25f](9f2b25f)) * **I18n:** NO-JIRA initialization tweaks ([#965](#965)) ([50bb929](50bb929)) ### Features * **Rich Text Editor:** NO-JIRA add mention click handling ([#1009](#1009)) ([6e2334f](6e2334f))
Brad Paugh (braddialpad)
pushed a commit
that referenced
this pull request
Jan 6, 2026
# [9.153.0](dialtone/v9.152.1...dialtone/v9.153.0) (2026-01-06) ### Bug Fixes * DLT-2878 stories using emoji row ([#1007](#1007)) ([9f2b25f](9f2b25f)) * **I18n:** NO-JIRA initialization tweaks ([#965](#965)) ([50bb929](50bb929)) ### Features * **Rich Text Editor:** NO-JIRA add mention click handling ([#1009](#1009)) ([6e2334f](6e2334f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: DLT-2878 stories using emoji row
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
DLT-2878
📖 Description
The problem was that
getCurrentInstance()when initializing localization was being called outside of a Vue context. Created a composable so that the storybook components can get the mocked data with the translated names from there, instead of calling directly the constructor forDialtoneLocalizationin the storybook module.📷 Screenshots / GIFs