Skip to content

feat(loader,progress-circle): NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle#1102

Merged
Francis Rupert (francisrupert) merged 9 commits intostagingfrom
improve-progress-circle-visuals
Mar 5, 2026
Merged

feat(loader,progress-circle): NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle#1102
Francis Rupert (francisrupert) merged 9 commits intostagingfrom
improve-progress-circle-visuals

Conversation

@francisrupert
Copy link
Copy Markdown
Contributor

@francisrupert Francis Rupert (francisrupert) commented Mar 4, 2026

image

🛠️ Type Of Change

  • Feature

📖 Jira Ticket

NO-JIRA

📖 Description

  • Added stroke-linecap="round" to DtProgressCircle fill shape
  • Polished DtProgressCircle stroke rendering with rounded linecaps and minimum visual thresholds
  • Replaced DtIconLoading icon import in DtLoader with an inline SVG spinner arc that visually aligns with DtProgressCircle
  • Added a comet-fade conic-gradient mask to the loader icon so the leading edge fades to transparent

💡 Context

After landing the DtProgressCircle component, we aligned DtLoader (the indeterminate spinner) to use a matching SVG arc so the two components share a consistent visual language. The loader also gains a comet-tail fade effect via a CSS mask for a more polished spin animation.

📦 Cross-Package Impact

Package Changes Downstream Impact
dialtone-css Updated loader.less, progress_circle.less Vue components depend on these styles
dialtone-vue Updated DtLoader SVG, polished DtProgressCircle ---

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

For all CSS changes:

  • I have used design tokens whenever possible.
  • I have considered how this change will behave on different screen sizes.
  • I have visually validated my change in light and dark mode.
  • I have used gap or flexbox properties for layout instead of margin whenever possible.

🔮 Next Steps

  • Validate comet-fade visually in light and dark mode across all loader sizes
Screen.Recording.2026-03-04.at.4.26.47.PM.mov
Screen.Recording.2026-03-04.at.4.31.47.PM.mov

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@francisrupert Francis Rupert (francisrupert) changed the title feat(loader,progress-circle): NO-JIRA polish DtProgressCircle details and align DtLoader visual with DtProgressCircle feat(loader,progress-circle): NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle Mar 4, 2026
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes.

Comment thread packages/dialtone-vue/components/loader/loader.vue
Comment thread packages/dialtone-vue/components/progress_circle/progress_circle.vue Outdated
Comment thread packages/dialtone-vue/components/progress_circle/progress_circle.vue Outdated
Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! much prettier

Comment thread packages/dialtone-vue/components/loader/loader.vue
Comment thread packages/dialtone-vue/components/progress_circle/progress_circle.vue Outdated
Comment thread packages/dialtone-vue/components/progress_circle/progress_circle.vue Outdated
@braddialpad
Copy link
Copy Markdown
Contributor

Seems like there's a problem with the Progress Circle usage in Attachment Carousel
Screenshot 2026-03-04 at 3 08 12 PM

@francisrupert
Copy link
Copy Markdown
Contributor Author

Francis Rupert (francisrupert) commented Mar 4, 2026

Seems like there's a problem with the Progress Circle usage...

eek. will probe. EDIT: oh, it's using var(--dt-color-neutral-white) on carousel css.

@francisrupert
Copy link
Copy Markdown
Contributor Author

Francis Rupert (francisrupert) commented Mar 4, 2026

Seems like there's a problem with the Progress Circle usage...

Tweaked colors in attachement_carousel.less. There's a lot about that component that should still be polished, but good for now.

image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

✔️ Deploy previews ready!
😎 Dialtone documentation preview: https://dialtone.dialpad.com/deploy-previews/pr-1102/
😎 Dialtone-vue preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-1102/

Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks awesome thanks!

@francisrupert Francis Rupert (francisrupert) merged commit 7b9e9b6 into staging Mar 5, 2026
18 checks passed
@francisrupert Francis Rupert (francisrupert) deleted the improve-progress-circle-visuals branch March 5, 2026 01:11
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 5, 2026
# [8.74.0-next.3](dialtone-css/v8.74.0-next.2...dialtone-css/v8.74.0-next.3) (2026-03-05)

### Features

* **Button,tabs,split Button:** visual refresh and slot updates DLT-2946 DLT-2947 DLT-2965 ([#1090](#1090)) ([ffdd56f](ffdd56f))
* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 5, 2026
# [3.211.0-next.1](dialtone-vue/v3.210.0...dialtone-vue/v3.211.0-next.1) (2026-03-05)

### Bug Fixes

* **Combobox:** DLT-3057 combobox errors when hovering over dt-dropdown-separator ([#1097](#1097)) ([4798e0e](4798e0e))

### Code Refactoring

* **Combobox Multi Select:** NO-JIRA use logical css properties ([#1104](#1104)) ([a675daf](a675daf))
* **Components,recipes:** DLT-3043 DLT-3046 logical start/end naming with deprecated backward-compatible fallbacks ([#1079](#1079)) ([1d26a4e](1d26a4e))
* **Tokens:** DLT-3013 convert color system from HSL to OKLCH ([#1060](#1060)) ([42dc418](42dc418))

### Features

* **Avatar:** DLT-2942 updated avatar component ([#1047](#1047)) ([e50563d](e50563d))
* **Button,tabs,split Button:** visual refresh and slot updates DLT-2946 DLT-2947 DLT-2965 ([#1090](#1090)) ([ffdd56f](ffdd56f))
* **Link,button:** DLT-3012 add underline prop ([#1059](#1059)) ([1cb91ea](1cb91ea))
* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))
* **Text:** export text component from dialtone-vue ([757fdb7](757fdb7))
* **Tokens:** DLT-2937 introduce spacing and layout token systems ([#1045](#1045)) ([de23e12](de23e12))
* **Tokens:** update color ramps and consumer color migration tools DLT-3004 DLT-3005 DLT-3006 DLT-3007 DLT-3008 ([#1054](#1054)) ([28cb1de](28cb1de))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 5, 2026
# [9.167.0-next.1](dialtone/v9.166.0...dialtone/v9.167.0-next.1) (2026-03-05)

### Bug Fixes

* **Combobox:** DLT-3057 combobox errors when hovering over dt-dropdown-separator ([#1097](#1097)) ([4798e0e](4798e0e))
* **Doc:** NO-JIRA correct font size utility json ([#1015](#1015)) ([76cf0fa](76cf0fa))
* possible merge issue in sidebarItem.vue ([5e2e91b](5e2e91b))
* **Stylelint:** disable hue-degree-notation rule and update OKLCH color syntax ([81f886e](81f886e))
* **Stylelint:** disable hue-degree-notation rule and update OKLCH color syntax ([8721f43](8721f43))
* **Tokens:** DLT-3053 preserve root font size variable as reference ([#1093](#1093)) ([112ab4b](112ab4b))
* **Tokens:** handle multi-layer box shadows correctly in postcss plugin ([feea7f1](feea7f1))
* **Tokens:** NO-JIRA output line-height as unitless instead of percentages ([#1040](#1040)) ([33d8505](33d8505))
* **Tokens:** wrap css math expressions with calc() in layered build ([#966](#966)) ([1635f61](1635f61))
* update @dialpad/i18n dependencies to latest versions ([7a4b777](7a4b777))

### Code Refactoring

* **Combobox Multi Select:** NO-JIRA use logical css properties ([#1104](#1104)) ([a675daf](a675daf))
* **Components,recipes:** DLT-3043 DLT-3046 logical start/end naming with deprecated backward-compatible fallbacks ([#1079](#1079)) ([1d26a4e](1d26a4e))
* **Css:** DLT-1876 css logical properties ([#872](#872)) ([1acd6c9](1acd6c9))
* **Style:** DLT-3014 wrap all styles in css cascade layers ([#1061](#1061)) ([f8b3fed](f8b3fed))
* **Text:** DLT-2883 rename headline sizes from xxl => 2xl, etc ([#1029](#1029)) ([0ac86f3](0ac86f3))
* **Tokens:** DLT-2884 deprecate space tokens in favor of size tokens ([#1013](#1013)) ([63f6d2f](63f6d2f))
* **Tokens:** DLT-3013 convert color system from HSL to OKLCH ([#1060](#1060)) ([42dc418](42dc418))

### Documentation

* DLT-1510 DLT-1511 DLT-1512 site redesign and ia ([#968](#968)) ([6ea7eb9](6ea7eb9))
* DLT-2908 ui kits landing page ([#1049](#1049)) ([d805b9d](d805b9d))

### Features

* **Avatar:** DLT-2942 updated avatar component ([#1047](#1047)) ([e50563d](e50563d))
* **Button,tabs,split Button:** visual refresh and slot updates DLT-2946 DLT-2947 DLT-2965 ([#1090](#1090)) ([ffdd56f](ffdd56f))
* **Css Utility:** DLT-2715 add default color for border css utilities ([#874](#874)) ([71310ab](71310ab))
* **Filter Pill:** DLT-2704 create component ([#473](#473)) ([6267445](6267445))
* **Link,button:** DLT-3012 add underline prop ([#1059](#1059)) ([1cb91ea](1cb91ea))
* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))
* **Style:** DLT-2976 update underline thickness and offset ([#1058](#1058)) ([1e56947](1e56947))
* **Text:** export text component from dialtone-vue ([757fdb7](757fdb7))
* **Text:** new vue component DLT-2864 DLT-2863 DLT-2862 ([#995](#995)) ([196ef8a](196ef8a))
* **Tokens:** DLT-1977 add high contrast design tokens and theme ([#938](#938)) ([a1c0457](a1c0457))
* **Tokens:** DLT-2767 exploratory shell themes ([#909](#909)) ([3afcf63](3afcf63))
* **Tokens:** DLT-2781 create color-assistive themes ([#921](#921)) ([a6cc397](a6cc397))
* **Tokens:** DLT-2802 DLT-2563 layered theming system and mode island component ([#945](#945)) ([5c72c6c](5c72c6c))
* **Tokens:** DLT-2937 introduce spacing and layout token systems ([#1045](#1045)) ([de23e12](de23e12))
* **Tokens:** update color ramps and consumer color migration tools DLT-3004 DLT-3005 DLT-3006 DLT-3007 DLT-3008 ([#1054](#1054)) ([28cb1de](28cb1de))
* **Typography, Tokens:** DLT-2856 DLT-2857 next typography system ([#994](#994)) ([d744e97](d744e97))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 6, 2026
# [8.74.0](dialtone-css/v8.73.0...dialtone-css/v8.74.0) (2026-03-06)

### Features

* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 6, 2026
# [3.211.0](dialtone-vue/v3.210.0...dialtone-vue/v3.211.0) (2026-03-06)

### Bug Fixes

* **Combobox:** DLT-3057 combobox errors when hovering over dt-dropdown-separator ([#1097](#1097)) ([4798e0e](4798e0e))
* **Tooltip:** NO-JIRA add Shadow DOM support for DtTooltipDirective ([#1100](#1100)) ([121ffa2](121ffa2))

### Code Refactoring

* **Progress Circle:** NO-JIRA update ai gradient with css variables and fewer stops ([#1105](#1105)) ([8dd19ea](8dd19ea))

### Features

* **Editor:** NO-JIRA added props allowBackgroundColor & allowLineHeight ([#1103](#1103)) ([7c90308](7c90308))
* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Mar 6, 2026
# [9.167.0](dialtone/v9.166.0...dialtone/v9.167.0) (2026-03-06)

### Bug Fixes

* **Combobox:** DLT-3057 combobox errors when hovering over dt-dropdown-separator ([#1097](#1097)) ([4798e0e](4798e0e))
* **Tooltip:** NO-JIRA add Shadow DOM support for DtTooltipDirective ([#1100](#1100)) ([121ffa2](121ffa2))

### Code Refactoring

* **Progress Circle:** NO-JIRA update ai gradient with css variables and fewer stops ([#1105](#1105)) ([8dd19ea](8dd19ea))

### Features

* **Editor:** NO-JIRA added props allowBackgroundColor & allowLineHeight ([#1103](#1103)) ([7c90308](7c90308))
* **Loader,progress Circle:** NO-JIRA polish DtProgressCircle visual and align DtLoader visual with DtProgressCircle ([#1102](#1102)) ([7b9e9b6](7b9e9b6))
* **Progress Circle:** DLT-2983 add progress-circle component ([#1098](#1098)) ([c0f0e40](c0f0e40))

### Reverts

* NO-JIRA revert progress circle polish commits for re-PR ([#1101](#1101)) ([a212c41](a212c41))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-visual-test Add this tag when the PR does not need visual testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants