fix(editor): DP-179668 some toolbar buttons not returning focus to editor#1117
Merged
Maysam Kangarani Farahani (maysamkf) merged 1 commit intostagingfrom Mar 11, 2026
Merged
Conversation
Contributor
|
Please add either the |
Maysam Kangarani Farahani (maysamkf)
added
the
no-visual-test
Contributor
|
✔️ Deploy previews ready! |
Maysam Kangarani Farahani (maysamkf)
changed the title
Maysam Kangarani Farahani (maysamkf)
marked this pull request as ready for review
Brad Paugh (braddialpad)
approved these changes
Mar 11, 2026
Maysam Kangarani Farahani (maysamkf)
merged commit 67a2a64
into
staging
28 of 31 checks passed
Brad Paugh (braddialpad)
pushed a commit
that referenced
this pull request
Mar 12, 2026
## [3.215.1](dialtone-vue/v3.215.0...dialtone-vue/v3.215.1) (2026-03-12) ### Bug Fixes * **Editor:** DP-179668 some toolbar buttons not returning focus to editor ([#1117](#1117)) ([67a2a64](67a2a64)) * **Popover:** DP-175009 revert visibility CSS that caused tippy-box click stealing ([#1119](#1119)) ([82ffcb6](82ffcb6))
Brad Paugh (braddialpad)
pushed a commit
that referenced
this pull request
Mar 12, 2026
## [9.171.1](dialtone/v9.171.0...dialtone/v9.171.1) (2026-03-12) ### Bug Fixes * **Editor:** DP-179668 some toolbar buttons not returning focus to editor ([#1117](#1117)) ([67a2a64](67a2a64)) * **Popover:** DP-175009 revert visibility CSS that caused tippy-box click stealing ([#1119](#1119)) ([82ffcb6](82ffcb6))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some toolbar buttons not returning focus to editor
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DP-179668
📖 Description
close(cb)that is called after the popover/dropdown fully closesclose()is passedfocusEditoras the callback so the editor regains focus after close💡 Context
When selecting a value from the font style, font size, or variable popover, focus returns to the toolbar button instead of the editor.
This is not expected as all other editor toolbar buttons return focus to the editor.
📝 Checklist
For all PRs:
For all Vue changes:
📷 Screenshots / GIFs
Observed bug:
Screen.Recording.2026-03-10.at.3.53.20.PM.mov
Fix:
Screen.Recording.2026-03-10.at.3.38.38.PM.mov