Skip to content

fix: DLT-2392 add optional chaining to intersection observer disconnect#660

Merged
eabrakov merged 1 commit intostagingfrom
DLT-2392-intersection-observer
Mar 3, 2025
Merged

fix: DLT-2392 add optional chaining to intersection observer disconnect#660
eabrakov merged 1 commit intostagingfrom
DLT-2392-intersection-observer

Conversation

@eabrakov
Copy link
Copy Markdown
Contributor

@eabrakov eabrakov commented Mar 3, 2025

fix: DLT-2392 add optional chaining to intersection observer disconnect

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

📖 Description

Optional chain added to intersection observer disconnect

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2025

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-660/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-660/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-660/

@braddialpad Brad Paugh (braddialpad) added the no-visual-test Add this tag when the PR does not need visual testing label Mar 3, 2025
@eabrakov eabrakov merged commit e6e04e0 into staging Mar 3, 2025
@eabrakov eabrakov deleted the DLT-2392-intersection-observer branch March 3, 2025 23:49
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Mar 13, 2025
## [2.177.1](dialtone-vue2/v2.177.0...dialtone-vue2/v2.177.1) (2025-03-04)

### Bug Fixes

* DLT-2392 add optional chaining to intersection observer disconnect ([#660](#660)) ([e6e04e0](e6e04e0))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Mar 13, 2025
## [3.170.1](dialtone-vue3/v3.170.0...dialtone-vue3/v3.170.1) (2025-03-04)

### Bug Fixes

* DLT-2392 add optional chaining to intersection observer disconnect ([#660](#660)) ([e6e04e0](e6e04e0))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Mar 13, 2025
## [9.104.1](dialtone/v9.104.0...dialtone/v9.104.1) (2025-03-04)

### Bug Fixes

* DLT-2392 add optional chaining to intersection observer disconnect ([#660](#660)) ([e6e04e0](e6e04e0))

### Documentation

* NO-JIRA automate utility classes extraction ([#654](#654)) ([7a53512](7a53512))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-visual-test Add this tag when the PR does not need visual testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants