Skip to content

feat(linters): DLT-2395 base color linter rules#667

Merged
Julio Ortega (juliodialpad) merged 4 commits intorebrand-2025-betafrom
base-color-linter-rules
Mar 12, 2025
Merged

feat(linters): DLT-2395 base color linter rules#667
Julio Ortega (juliodialpad) merged 4 commits intorebrand-2025-betafrom
base-color-linter-rules

Conversation

@juliodialpad
Copy link
Copy Markdown
Contributor

@juliodialpad Julio Ortega (juliodialpad) commented Mar 11, 2025 •
edited
Loading

Add base color deprecation linter rules

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Feature

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2395

📖 Description

  • Added ESLint and StyleLint rules to discourage developers from using base color utility classes and tokens.

💡 Context

  • We're making an effort on making everyone aware that they should be using semantic colors exclusively, base colors should be used in very rare cases only.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.

🔮 Next Steps

Release and enable this rules on product once the rebranding is done.

@juliodialpad
update pnpm-lock
5093739 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
add deprecated base color classes eslint rule
8305a93 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
fix deprecation eslint warning
6420415 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
add deprecated base tokens stylelint rule
74b5414 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad Julio Ortega (juliodialpad) added the no-visual-test Add this tag when the PR does not need visual testing label Mar 11, 2025
@juliodialpad Julio Ortega (juliodialpad) changed the base branch from staging to rebrand-2025-beta March 11, 2025 19:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-667/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-667/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-667/

@juliodialpad Julio Ortega (juliodialpad) changed the title feat(linters): DLT-2395 Base color linter rules feat(linters): DLT-2395 base color linter rules Mar 11, 2025
@juliodialpad Julio Ortega (juliodialpad) marked this pull request as ready for review March 11, 2025 22:03
francisrupert
Francis Rupert (francisrupert) approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@francisrupert Francis Rupert (francisrupert) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me late. approve at least from my perpective.

ninamarina
Nina Repetto (ninamarina) approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ninamarina Nina Repetto (ninamarina) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@juliodialpad Julio Ortega (juliodialpad) merged commit a23e3c6 into rebrand-2025-beta Mar 12, 2025
10 of 11 checks passed
@juliodialpad Julio Ortega (juliodialpad) deleted the base-color-linter-rules branch March 12, 2025 19:21
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 8, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.106.0-rebrand-2025-beta.1
024fbc2 
# [9.106.0-rebrand-2025-beta.1](dialtone/v9.105.0...dialtone/v9.106.0-rebrand-2025-beta.1) (2025-03-13)

### Bug Fixes

* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 8, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.108.0-rebrand-2025-beta.1
c6d819c 
# [9.108.0-rebrand-2025-beta.1](dialtone/v9.107.1...dialtone/v9.108.0-rebrand-2025-beta.1) (2025-04-07)

### Bug Fixes

* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA $el in vue 3 ([#690](#690)) ([0027ba7](0027ba7))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA dialtone icons android build ([#691](#691)) ([8c10768](8c10768))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))
* **Tooltip:** DP-129564 add overflow-wrap for tooltip ([#687](#687)) ([b6d8256](b6d8256))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 28, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.109.0-rebrand-2025-beta.1
c1338e4 
# [9.109.0-rebrand-2025-beta.1](dialtone/v9.108.0...dialtone/v9.109.0-rebrand-2025-beta.1) (2025-04-11)

### Bug Fixes

* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Icons:** [NO-JIRA] new icons dialpad-star ([#706](#706)) ([f38fefd](f38fefd))
* **Illustrations:** DLT-2424 add rebranded illustrations ([#693](#693)) ([6644761](6644761))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 28, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.112.0-rebrand-2025-beta.1
cdc7e4d 
# [9.112.0-rebrand-2025-beta.1](dialtone/v9.111.1...dialtone/v9.112.0-rebrand-2025-beta.1) (2025-04-22)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2441 add modal false ([#723](#723)) ([b031e78](b031e78))
* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))
* NO-JIRA vue 3 v-model corrections ([#711](#711)) ([2d5c646](2d5c646))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Icons:** [NO-JIRA] new icons dialpad-star ([#706](#706)) ([f38fefd](f38fefd))
* **Icons:** DLT-2494 revert update dialpad logo gradient ([#727](#727)) ([8b33df6](8b33df6))
* **Icons:** DLT-2494 update dialpad logo gradient ([#726](#726)) ([933bb7b](933bb7b))
* **Illustrations:** DLT-2424 add rebranded illustrations ([#693](#693)) ([6644761](6644761))
* **Illustrations:** NO-JIRA new illustrations added ([#718](#718)) ([6b45b79](6b45b79))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francisrupert Francis Rupert (francisrupert) francisrupert approved these changes

@iropolo Ignacio Ropolo (iropolo) Awaiting requested review from iropolo

@braddialpad Brad Paugh (braddialpad) Awaiting requested review from braddialpad

+1 more reviewer

@ninamarina Nina Repetto (ninamarina) ninamarina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@juliodialpad Julio Ortega (juliodialpad)

Labels

no-visual-test Add this tag when the PR does not need visual testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliodialpad @francisrupert @ninamarina