feat: DLT-2419 hideEdges + watcher on active page prop#675
Merged
Sanjeev Suresh (sanjeevdialpad) merged 2 commits intostagingfrom Mar 20, 2025
Merged
feat: DLT-2419 hideEdges + watcher on active page prop#675Sanjeev Suresh (sanjeevdialpad) merged 2 commits intostagingfrom
Sanjeev Suresh (sanjeevdialpad) merged 2 commits intostagingfrom
Conversation
Sanjeev Suresh (sanjeevdialpad)
changed the title
Brad Paugh (braddialpad)
requested changes
Mar 20, 2025
Sanjeev Suresh (sanjeevdialpad)
requested a review
from Brad Paugh (braddialpad)
Contributor
|
Please add either the |
Contributor
Author
|
Brad Paugh (@braddialpad) made all the changes! |
Contributor
|
✔️ Deploy previews ready! |
Brad Paugh (braddialpad)
approved these changes
Mar 20, 2025
Contributor
Brad Paugh (braddialpad)
left a comment
Brad Paugh (braddialpad)
left a comment
There was a problem hiding this comment.
Looks great thanks!
Brad Paugh (braddialpad)
added
the
visual-test-ready
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Mar 24, 2025
# [2.179.0](dialtone-vue2/v2.178.2...dialtone-vue2/v2.179.0) (2025-03-20) ### Features * DLT-2419 hideEdges + watcher on active page prop ([#675](#675)) ([67ef1e2](67ef1e2))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Mar 24, 2025
# [3.172.0](dialtone-vue3/v3.171.2...dialtone-vue3/v3.172.0) (2025-03-20) ### Features * DLT-2419 hideEdges + watcher on active page prop ([#675](#675)) ([67ef1e2](67ef1e2))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Mar 24, 2025
# [9.106.0](dialtone/v9.105.2...dialtone/v9.106.0) (2025-03-20) ### Features * DLT-2419 hideEdges + watcher on active page prop ([#675](#675)) ([67ef1e2](67ef1e2))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: hideEdges for lazy loading pagination and watcher on active page prop
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-2419
📖 Description
activePage prop is not reactive since its assigned to data on init, so we cannot control the pagination from outside this component which is needed sometimes.
Sometimes you may need to hide start and end page number buttons when moving in between.
This prop will be used to hide the first and last page buttons when not near the edges.
This is useful when your backend does not support offset and you can only use cursor based pagination.
💡 Context
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.shscript. Read docs here: Dialtone Vue Sync Script