fix(pagination): DLT-2373 invalid prop combination on end buttons#684
Merged
Brad Paugh (braddialpad) merged 3 commits intostagingfrom Mar 31, 2025
Merged
fix(pagination): DLT-2373 invalid prop combination on end buttons#684Brad Paugh (braddialpad) merged 3 commits intostagingfrom
Brad Paugh (braddialpad) merged 3 commits intostagingfrom
Conversation
Brad Paugh (braddialpad)
added
the
visual-test-ready
Julio Ortega (juliodialpad)
suggested changes
Mar 28, 2025
| :disabled="isLastPage" | ||
| kind="muted" | ||
| :importance="isLastPage ? 'primary' : 'clear'" | ||
| :class="isLastPage ? 'd-fc-black-300 d-bgc-transparent' : 'd-fc-tertiary'" |
Contributor
There was a problem hiding this comment.
You removed this classes that's why the Percy tests detected changes.
Those classes shouldn't be there anyways haven't we removed all utility classes from components?
Can you please update this?
Contributor
Author
There was a problem hiding this comment.
ah yeah, it's because the default disabled styling makes it "filled". Added the specific disabled styling to the less file, fixed.
| } | ||
|
|
||
| if (this.currentPage > end) { | ||
| console.log('END=', end); |
Contributor
There was a problem hiding this comment.
Forgot to remove console log
Contributor
Author
There was a problem hiding this comment.
I did remove it that's why it's red 😄.
Contributor
There was a problem hiding this comment.
🙃 my bad haha
Contributor
|
✔️ Deploy previews ready! |
Julio Ortega (juliodialpad)
approved these changes
Mar 29, 2025
Contributor
Julio Ortega (juliodialpad)
left a comment
Julio Ortega (juliodialpad)
left a comment
There was a problem hiding this comment.
Perfect! that's way more clear, thanks.
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 3, 2025
## [8.50.4](dialtone-css/v8.50.3...dialtone-css/v8.50.4) (2025-03-31) ### Bug Fixes * **Pagination:** DLT-2373 invalid prop combination on end buttons ([#684](#684)) ([517debb](517debb))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 3, 2025
# [2.180.0](dialtone-vue2/v2.179.1...dialtone-vue2/v2.180.0) (2025-03-31) ### Bug Fixes * **Pagination:** DLT-2373 invalid prop combination on end buttons ([#684](#684)) ([517debb](517debb)) ### Features * **Editor:** DP-131851 added editor support to encase text with div tags ([#685](#685)) ([d0429a3](d0429a3))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 3, 2025
# [3.173.0](dialtone-vue3/v3.172.1...dialtone-vue3/v3.173.0) (2025-03-31) ### Bug Fixes * **Pagination:** DLT-2373 invalid prop combination on end buttons ([#684](#684)) ([517debb](517debb)) ### Features * **Editor:** DP-131851 added editor support to encase text with div tags ([#685](#685)) ([d0429a3](d0429a3))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 3, 2025
# [9.107.0](dialtone/v9.106.1...dialtone/v9.107.0) (2025-03-31) ### Bug Fixes * **Pagination:** DLT-2373 invalid prop combination on end buttons ([#684](#684)) ([517debb](517debb)) ### Features * **Editor:** DP-131851 added editor support to encase text with div tags ([#685](#685)) ([d0429a3](d0429a3))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(pagination): DLT-2373 invalid prop combination on end buttons
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-2373
📖 Description
Removed unnecessary conditionals from kind and importance props on the end "arrow" buttons in the pagination component.
💡 Context
It was possible for the pagination component end buttons to display a "primary muted" button which is an invalid combination. Found that the kind and importance conditionals for the end buttons were not even needed anyways.
📝 Checklist
For all PRs: