Skip to content

fix(emoji-text-wrapper): DLT-2455 skip vue3 comment vnodes when extracting text for emojis#686

Merged
Noelle Levy (noellelevydialpad) merged 1 commit intostagingfrom
noelle/emoji-comment-text
Apr 1, 2025
Merged

fix(emoji-text-wrapper): DLT-2455 skip vue3 comment vnodes when extracting text for emojis#686
Noelle Levy (noellelevydialpad) merged 1 commit intostagingfrom
noelle/emoji-comment-text

Conversation

@noellelevydialpad
Copy link
Copy Markdown
Contributor

@noellelevydialpad Noelle Levy (noellelevydialpad) commented Apr 1, 2025

PR Title

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2455

📖 Description

Skip vue3 comment vnodes when searching for text to emojify. In vue3 internals, comment vnodes look a lot like other html vnodes with text children.

💡 Context

The placeholder comments vue produces for v-if elements which were not currently rendering were being placed into the document as the string v-if after the emoji processing.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all Vue changes:

  • I have added / updated unit tests.
  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
  • I have validated components with a screen reader.
  • I have validated components keyboard navigation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@noellelevydialpad Noelle Levy (noellelevydialpad) added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Apr 1, 2025
@noellelevydialpad Noelle Levy (noellelevydialpad) changed the title fix(emoji-text-wrapper): DLT-2455 Skip vue3 comment vnodes when extracting text for emojis fix(emoji-text-wrapper): DLT-2455 skip vue3 comment vnodes when extracting text for emojis Apr 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-686/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-686/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-686/

braddialpad
Brad Paugh (braddialpad) approved these changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@noellelevydialpad Noelle Levy (noellelevydialpad) merged commit 62ad982 into staging Apr 1, 2025
14 of 15 checks passed
@noellelevydialpad Noelle Levy (noellelevydialpad) deleted the noelle/emoji-comment-text branch April 1, 2025 17:36
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.180.1
63bff7d 
## [2.180.1](dialtone-vue2/v2.180.0...dialtone-vue2/v2.180.1) (2025-04-02)

### Bug Fixes

* **Ci:** NO-JIRA changelog release order ([#689](#689)) ([bd4c080](bd4c080))
* **Emoji Text Wrapper:** DLT-2455 skip vue3 comment vnodes when extracting text for emojis ([#686](#686)) ([62ad982](62ad982))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.173.1
43a0a5b 
## [3.173.1](dialtone-vue3/v3.173.0...dialtone-vue3/v3.173.1) (2025-04-02)

### Bug Fixes

* **Ci:** NO-JIRA changelog release order ([#689](#689)) ([bd4c080](bd4c080))
* **Emoji Text Wrapper:** DLT-2455 skip vue3 comment vnodes when extracting text for emojis ([#686](#686)) ([62ad982](62ad982))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.107.1
ec699bb 
## [9.107.1](dialtone/v9.107.0...dialtone/v9.107.1) (2025-04-02)

### Bug Fixes

* **Ci:** NO-JIRA changelog release order ([#689](#689)) ([bd4c080](bd4c080))
* **Emoji Text Wrapper:** DLT-2455 skip vue3 comment vnodes when extracting text for emojis ([#686](#686)) ([62ad982](62ad982))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braddialpad Brad Paugh (braddialpad) braddialpad approved these changes

@juliodialpad Julio Ortega (juliodialpad) Awaiting requested review from juliodialpad

@iropolo Ignacio Ropolo (iropolo) Awaiting requested review from iropolo iropolo is a code owner

@francisrupert Francis Rupert (francisrupert) Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina Nina Repetto (ninamarina) Awaiting requested review from ninamarina

Assignees

No one assigned

Labels

visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noellelevydialpad @braddialpad