-
Notifications
You must be signed in to change notification settings - Fork 23
Install all dependencies with APT, reduce verbosity in Makefile build #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will run the Docker CMake build with If so, we could add something to that effect to @dwpaley Opinions? |
Obsoletes conda for the Python dependencies. Matplotlib (python3-matplotlib in Ubuntu) does not appear to be needed at the moment. Capitalize the GitHub Action step names for consistency.
Remove -v (--verbose) option from rsync and tar. Do not store intermediate downloads and elide seemingly redundant touch:es. Note that http://downloads.sf.net/cbflib/PyCifRW-4.3_rev_19Jun21.tar.gz ($(PY3CIFRWURL)) appears to be an uncompressed tarfile, despite its .gz extension.
Use e.g. --cpuset-cpus or --cpu-quota to externally limit CPU usage with docker. The analogous make -j may not work for the Makefile build, because make is run recursively.
Affects the regeneration of e.g. the SWIG interface files. This is arguably a buildsystem bug.
|
Without objection here on the It's funny that About the source of the Python dependencies--I worry a bit because when installing thru APT we have less flexibility to choose versions. Currently APT on ubuntu 24:04 gives python 3.12.3 and Numpy 1.26.4; |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: install extra dependencies | ||
| - name: Install extra dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, maybe my shift key is defective
Thanks, Dan! I'm not overly concerned about the different Python versions. The SWIG step, which I suppose is what the tests are supposed to exercise, doesn't really depend on Python. But the module that a Python interpreter builds from the SWIG output is specific to the version of the interpreter. I think I see your point, though: if the SWIG input has bunch of version-conditionals there could be trouble! Nevertheless, given your approval, I'll merge this unless there are any objections within the next day or so. |
|
Definitely fine to merge. I was thinking of the version of numpy that the tests run on. The tests contain some lines like: |
Runs the CMake build with
nprocCPUs everywhere; this may not work for the Makefile build, on account of recursive invocations ofmake. Also, using--parallelwithcmakein MSYS2 sinks the ship!